fix(ja4t): align Rust JA4T output with Wireshark/Zeek - #310
Conversation
|
JA4T numeric fields are formatted as decimal values, while @john-althouse, since this behavior is not currently documented publicly, should we add it somewhere? |
Keep the contributor's Wireshark/Zeek-compatible formatter and add a regression test showing that a present single-digit MSS uses a minimum width of two decimal digits.
|
I rechecked this against the Wireshark and Zeek implementations. Both treat a missing value and an actual zero the same here, so your current implementation is consistent with them. Please ignore my previous comment. @john-althouse, it might be worth clarifying this in the spec. |
08c6221 to
de9b181
Compare
|
Thanks for the PR, and sorry for the confusion around the I rebased the branch and added a small test for it. Everything looks good now - I’m going to merge this. |
This PR aligns Rust with Wireshark/Zeek on:
(window scale stays unpadded when nonzero, matching Wireshark)
instead of first
Still unresolved:
but ignored by Wireshark/Zeek).
Partially addresses #304