fix: inline SDK version instead of reading package.json at runtime - #294
Merged
Conversation
gagantrivedi
approved these changes
Sep 2, 2026
4 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Thanks for submitting a PR! Please check the boxes below:
docs/if required so people know about the feature.Changes
getUserAgent()read the SDK version withrequire('../package.json')at request time. This never worked in the published package (the relative path resolves tobuild/esm/package.jsonor thebuild/cjs/package.jsonstub, so the header always reportedunknown), and under bundlers such as Vite therequirecan be rewritten into a form that escapes thetry/catchand crashes the host application.sdk/version.tsconstant; no filesystem orrequireaccess at runtime.sdk/version.tsas a release-pleaseextra-filesentry so the constant is bumped on every release.How did you test this code?
npm testandnpm run test:esm-buildpass.vite build --ssr(Vite 8), ran the bundle from a separate directory: the request sendsUser-Agent: flagsmith-nodejs-sdk/9.0.1and the bundle contains nopackage.jsonreference.