fix: BuildPath drops string placeholder values, sending requests to the wrong URL - #7
Open
childish-sambino wants to merge 1 commit into
Open
Conversation
childish-sambino
marked this pull request as ready for review
July 7, 2026 22:25
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
BuildPath only recognized
map[string]interface{}, so themap[string]stringthatfile.Getpasses failed the type assertion and the{path}placeholder was silently replaced with an empty string. Everyfile.Get(path)requestedGET /files/(the root) regardless of the argument.The value-conversion switch also only assigned string values for the literal
pathplaceholder, so any other string-valued placeholder was blanked.chat_session.Find(ChatSessionFindParams{Id: "abc123"})sendsGET /chat_sessions/instead of/chat_sessions/abc123.Added BuildPath tests for both; they fail without the fix.
🤖 Generated by Quad tha God