fix(config): close resource streams#45
Open
Federico2014 wants to merge 1 commit into
Open
Conversation
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This PR fixes resource stream handling in configuration and startup utility code. It replaces a classpath resource existence check with
getResource(), wrapsgit.propertiesresource loading in try-with-resources, and closes the zk parameter resource stream after copying it to a temporary file.Why are these changes required?
Some
getResourceAsStream()call sites opened resource streams without closing them. This can leak file handles or jar resource handles in long-running processes or repeated utility calls. The zk parameter loading path also now fails clearly when the expected resource is missing instead of passing a null stream into file copy logic.This PR has been tested by:
git diff --check./gradlew :common:compileJava :framework:compileJavaFollow up
None.
Extra details
This PR does not change configuration semantics. It only avoids unnecessary stream creation and ensures opened classpath resource streams are closed.