Escape colon in XML names written by escaping XmlNameProcessors - #921
Open
Sahana2524 wants to merge 1 commit into
Open
Sahana2524 wants to merge 1 commit into
Sahana2524 wants to merge 1 commit into
Conversation
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Colon passes through the escaping name processors
Base64NameProcessorcounts a name holding a colon as already valid, andReplaceNameProcessorkeeps the colon in its allowed set, so a content-derived name such as aMapkey"a:b"is written out verbatim. Output is namespace-aware, so that colon comes back as a prefix nothing declares and the document no longer reads:<DTO><badMap><a:b>v</a:b></badMap></DTO>fails withUndeclared namespace prefix "a", while"a:b:c"and":leading"do not even parse. That round trip is what these two processors are there to protect, andnewAlwaysOnBase64Processor()already handles the same keys cleanly, so the colon looks like an oversight in the allowed sets rather than a deliberate exception.Dropping it means such names get escaped (base64, still a lossless round trip) or replaced instead. Only
encodeNamechanges:decodeNamekeys off the prefix for base64 and is a no-op for replacement, so names coming from a non-namespace-aware parser are still passed through untouched. Covered by round-trip tests inXmlNameEscapeTest; the rest of the suite is unchanged.