Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
Expand Up @@ -313,12 +313,14 @@ protected void _serializePropertiesFiltered(Object bean, JsonGenerator gen0,
xgen.setNextName(xmlNames[i]);
BeanPropertyWriter prop = props[i];
if (prop != null) { // can have nulls in filtered list
// [databind#6136]: let writer route filtering (any-getter
// filters per entry; view-based writers check view first)
if ((cdata != null) && cdata.get(i)) {
xgen.setNextIsCData(true);
filter.serializeAsProperty(bean, xgen, ctxt, prop);
prop.serializeFilteredAsProperty(bean, xgen, ctxt, filter);
xgen.setNextIsCData(false);
} else {
filter.serializeAsProperty(bean, xgen, ctxt, prop);
prop.serializeFilteredAsProperty(bean, xgen, ctxt, filter);
}
}
// Reset to avoid next value being written as unwrapped,
Expand Down
Original file line number Diff line number Diff line change
@@ -1,7 +1,11 @@
package tools.jackson.dataformat.xml.ser;

import java.util.LinkedHashMap;
import java.util.Map;

import org.junit.jupiter.api.Test;

import com.fasterxml.jackson.annotation.JsonAnyGetter;
import com.fasterxml.jackson.annotation.JsonFilter;
import com.fasterxml.jackson.annotation.JsonPropertyOrder;

Expand Down Expand Up @@ -32,6 +36,21 @@ static class Item
public int c;
}

// [databind#6136]: any-getter entries must be filtered per entry
@JsonFilter("filter")
static class AnyBean
{
public String name = "bob";

@JsonAnyGetter
public Map<String, String> anyProperties() {
Map<String, String> m = new LinkedHashMap<>();
m.put("a", "1");
m.put("secret", "s3cr3t");
return m;
}
}

@Test
public void testPullRequest616() throws Exception
{
Expand Down Expand Up @@ -62,4 +81,28 @@ public void serializeAsProperty(Object pojo, JsonGenerator g,
.build();
assertEquals(exp, xmlMapper.writeValueAsString(bean));
}

// [databind#6136]
@Test
public void anyGetterWithExcludingFilter() throws Exception
{
XmlMapper xmlMapper = XmlMapper.builder()
.filterProvider(new SimpleFilterProvider().addFilter("filter",
SimpleBeanPropertyFilter.serializeAllExcept("secret")))
.build();
assertEquals("<AnyBean><name>bob</name><a>1</a></AnyBean>",
xmlMapper.writeValueAsString(new AnyBean()));
}

// [databind#6136]
@Test
public void anyGetterWithIncludingFilter() throws Exception
{
XmlMapper xmlMapper = XmlMapper.builder()
.filterProvider(new SimpleFilterProvider().addFilter("filter",
SimpleBeanPropertyFilter.filterOutAllExcept("name", "a")))
.build();
assertEquals("<AnyBean><name>bob</name><a>1</a></AnyBean>",
xmlMapper.writeValueAsString(new AnyBean()));
}
}
Loading