Repository navigation
Drop pwgen depends - #8
Merged
Merged
Conversation
Contributor
There was a problem hiding this comment.
Copilot review overview
🟡 Changes recommended
Secret length validation and shell glob characters can cause hangs, empty secrets, or incorrectly configured passwords.
Review effort: Balanced
Findings: 2
Open (2)
What changed in this PR
Removes the pwgen dependency while improving secret generation and fcli command handling.
Changes:
- Generates secrets from
/dev/urandom. - Propagates
fcliexit codes andJSON_MODE. - Removes
pwgeninstallation from CI.
| File | Description |
|---|---|
scripts/init_secrets.sh |
Replaces pwgen with native secret generation. |
scripts/fcli_wrapper.sh |
Uses exec and forwards JSON_MODE. |
.github/workflows/reusable-compose.yml |
Removes the obsolete dependency installation. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
pwgen not needed now, little update for fcli_wrapper (better return code)