Conversation
With `updateImages: true` the comparison is skipped and the new screenshot is meant to become the baseline, but the write was gated on `createMissingImages` only. With `createMissingImages: false` the task therefore failed with "Baseline image is missing" even when the baseline existed and the user had explicitly asked for it to be updated. Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
Member
Author
|
It's good - we want to allow user to enable image updating but without creation of new images (for not covered yet paths) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
With
updateImages: truewe skip the comparison and the new screenshot is supposed to become the baseline. But the actual write was gated oncreateMissingImagesonly, so withcreateMissingImages: falsethe task failed with "Baseline image is missing" even when the baseline existed and the user explicitly asked to update it.Small condition change plus two tests (baseline present, baseline missing).
馃 Generated with Claude Code