Skip to content

fix: redact CLI transport diagnostics - #345

Merged
chubes4 merged 1 commit into
mainfrom
fix-341-redact-cli-output
Aug 6, 2026
Merged

fix: redact CLI transport diagnostics#345
chubes4 merged 1 commit into
mainfrom
fix-341-redact-cli-output

Conversation

@chubes4

@chubes4 chubes4 commented Aug 6, 2026

Copy link
Copy Markdown
Member

Summary

  • redact generic credentials, authorization/cookie headers, credentialed URLs, secret query parameters, and known environment values before bounding child-process diagnostics
  • remove stdout/stderr from successful synchronous metadata and keep failure details in bounded, redacted WP_Error data instead of error messages
  • cover sync, timeout, and detached boundaries plus multiline output, truncation order, configured values, and false-positive resistance

Validation

  • php tests/smoke-cli-transport.php
  • bash tests/cli-transport-install.sh
  • PHP syntax checks for the transport template and smoke test
  • bash -n across all repository shell scripts
  • git diff --check
  • full tests/*.sh suite run; it exposed an unrelated existing late-assertion failure-gate defect tracked in test: source-mode assertions after failure gate do not fail CI #344

Closes #341

@chubes4
chubes4 merged commit 88b6cf6 into main Aug 6, 2026
36 of 43 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

security: redact CLI child output before returning transport diagnostics

1 participant