Assign Iceberg field IDs recursively in list elements - #91
Merged
osipovartem merged 1 commit intoSep 25, 2026
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
new_fields_with_idsassigned an ID to a list element but not to fields inside a struct element. Iceberg table creation forARRAY(OBJECT(v VARIANT))then failed with a missing Parquet field ID.Change
Result<Fields, Error>API through the two fork planner callsites.Validation
i32::MAX, and exhaustion.cargo +1.95.0 test -p iceberg-rust-spec --lib: 181 passed, 1015 ignored.cargo +1.95.0 check -p datafusion_iceberg -p datafusion-iceberg-sql.cargo +1.95.0 clippy -p iceberg-rust-spec -p datafusion_iceberg -p datafusion-iceberg-sql --all-targets --all-features -- -D warnings; formatting check.Downstream callers of
new_fields_with_idsmust handleResult; Rustice callsites are being updated.