Skip to content
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
57 changes: 55 additions & 2 deletions iceberg-rust-spec/src/spec/manifest.rs
Original file line number Diff line number Diff line change
Expand Up @@ -660,10 +660,10 @@ impl DataFile {
.flatten()
{
for (field_id, value) in bounds {
let Some(field) = schema.fields().get(*field_id as usize) else {
let Some(field_type) = field_type_by_id(schema.fields(), *field_id) else {
continue;
};
match (&*value, &field.field_type) {
match (&*value, field_type) {
(Value::Int(inner), Type::Primitive(PrimitiveType::Long)) => {
*value = Value::LongInt(i64::from(*inner));
}
Expand All @@ -682,6 +682,42 @@ impl DataFile {
}
}

fn field_type_by_id(fields: &StructType, field_id: i32) -> Option<&Type> {
if let Ok(field_id) = usize::try_from(field_id) {
if let Some(field) = fields.get(field_id) {
return Some(&field.field_type);
}
}

fields
.iter()
.find_map(|field| nested_type_by_id(&field.field_type, field_id))
}

fn nested_type_by_id(data_type: &Type, field_id: i32) -> Option<&Type> {
match data_type {
Type::Primitive(_) => None,
Type::Struct(fields) => field_type_by_id(fields, field_id),
Type::List(list) => {
if list.element_id == field_id {
Some(&list.element)
} else {
nested_type_by_id(&list.element, field_id)
}
}
Type::Map(map) => {
if map.key_id == field_id {
Some(&map.key)
} else if map.value_id == field_id {
Some(&map.value)
} else {
nested_type_by_id(&map.key, field_id)
.or_else(|| nested_type_by_id(&map.value, field_id))
}
}
}
}

impl DataFile {
pub(crate) fn try_from_v3(
value: DataFileV3,
Expand Down Expand Up @@ -1930,6 +1966,19 @@ mod tests {
Type::Primitive(PrimitiveType::Double),
None,
),
StructField::new(
3,
"nested",
false,
Type::Struct(StructType::new(vec![StructField::new(
4,
"integer_value",
false,
Type::Primitive(PrimitiveType::Long),
None,
)])),
None,
),
]),
1,
None,
Expand All @@ -1949,10 +1998,12 @@ mod tests {
lower_bounds: Some(HashMap::from([
(1, Value::Int(7)),
(2, Value::Float(OrderedFloat(1.5))),
(4, Value::Int(11)),
])),
upper_bounds: Some(HashMap::from([
(1, Value::Int(9)),
(2, Value::Float(OrderedFloat(2.5))),
(4, Value::Int(13)),
])),
key_metadata: None,
split_offsets: None,
Expand All @@ -1971,13 +2022,15 @@ mod tests {
Some(&HashMap::from([
(1, Value::LongInt(7)),
(2, Value::Double(OrderedFloat(1.5))),
(4, Value::LongInt(11)),
]))
);
assert_eq!(
data_file.upper_bounds().as_ref(),
Some(&HashMap::from([
(1, Value::LongInt(9)),
(2, Value::Double(OrderedFloat(2.5))),
(4, Value::LongInt(13)),
]))
);
}
Expand Down
Loading