Promote manifest bounds after schema evolution - #85
Merged
osipovartem merged 1 commit intoSep 22, 2026
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
intlower/upper bounds tolongwhen a manifest is rewritten under an evolved schemafloatbounds todoublethrough the same metadata-only pathWhy
Iceberg allows
int -> long,float -> double, and decimal precision widening without rewriting data files. When an append rewrites existing manifest entries under the current schema, old four-byte int/float bounds must be promoted before the new manifest is serialized. Otherwise readers decode those bytes using the widened schema and fail withcould not convert slice to array. Decimal bounds need no byte rewrite because their minimal two's-complement encoding is precision-independent.This is a manifest-metadata path only; it adds no per-row conversion or query execution overhead.
Validation
cargo +1.95.0 test -p iceberg-rust-spec promotes_manifest_bounds_to_evolved_schemacargo +1.95.0 check -p iceberg-rustcargo +1.95.0 clippy -p iceberg-rust-spec -p iceberg-rust --all-targets -- -D warningsint -> long,float -> double, and decimal precision widening; reload catalog; read both files; exercise predicate pruning