Apply position deletes at equal sequence numbers - #81
Merged
osipovartem merged 1 commit intoSep 17, 2026
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Iceberg v2 requires position deletes to apply when
delete_sequence_number >= data_sequence_number. The existing filter used strict>, which could expose rows deleted in the same sequence. Equality deletes intentionally retain their separate strict sequence semantics.Performance
This changes only the comparison operator inside the existing vectorized DataFusion join filter. It adds no per-row scalar conversion, materialization, or work to scans without position deletes. Replacing the current hash anti-join with Apache-style delete bitmaps and Parquet row selection will be evaluated separately with benchmarks.
Verification
cargo +1.95.0 test -p datafusion_iceberg position_deletes_include_equal_data_sequence_numberscargo +1.95.0 test -p datafusion_iceberg --test position_deletecargo +1.95.0 clippy -p datafusion_iceberg --all-targets -- -D warningscargo +1.95.0 fmt --all -- --check