Skip to content

Adapt DF55 to MERGE ALL BY NAME parser AST - #85

Merged
osipovartem merged 1 commit into
embucket-sync-df55.0.0from
snowflake-merge-all-by-name-parser
Sep 12, 2026
Merged

osipovartem merged 1 commit into
embucket-sync-df55.0.0from
snowflake-merge-all-by-name-parser

Conversation

@osipovartem

Copy link
Copy Markdown
Collaborator

Summary

  • update the DF55 parser pin to the Snowflake MERGE ... ALL BY NAME AST revision
  • adapt explicit update assignments to MergeUpdateKind::Set
  • reject name-based update/insert explicitly in the generic DataFusion planner so downstream planners cannot silently interpret them as empty assignments

Scope

Rustice owns the actual name-based expansion because its MERGE planner must exclude Iceberg metadata and internal row-state columns. This PR is the minimal parser API adaptation for the shared DataFusion fork.

Validation

  • cargo +1.95.0 check -p datafusion-sql --all-targets
  • cargo +1.95.0 test -p datafusion-sql merge --lib
  • cargo +1.95.0 fmt --all -- --check

@osipovartem
osipovartem merged commit 1651a8f into embucket-sync-df55.0.0 Sep 12, 2026
18 of 20 checks passed
@osipovartem
osipovartem deleted the snowflake-merge-all-by-name-parser branch September 12, 2026 21:15
@github-actions github-actions Bot added the sql label Sep 12, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant