Support ORDER BY ALL for projected expressions - #83
Merged
osipovartem merged 1 commit intoSep 12, 2026
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
ORDER BY ALLto select-list ordinal positions instead of requiring raw column expressionsSortExecpath with no row-wise conversionSnowflake validation
Compared against Snowflake on 2026-09-12 using focused queries. Computed expressions, explicit null ordering, set operations, and grouped aggregate output matched exactly. The oracle warehouse was suspended immediately afterward.
A fresh Snowflake check also showed that aggregate outputs are currently accepted with
ORDER BY ALL, despite the current documentation note stating otherwise; tests follow observed engine behavior.Validation
cargo +1.95.0 fmt --all -- --checkcargo +1.95.0 test -p datafusion-sqllogictest --test sqllogictests -- order_by_all.slt --test-threads 1cargo +1.95.0 test -p datafusion-sql --test sql_integration -- --test-threads 8(604 passed)cargo +1.95.0 clippy -p datafusion-sql --all-targets -- -D warnings