feat(sql): support FETCH row limits - #82
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
FETCH FIRST|NEXT <count> ROWS ONLYthrough DataFusion's existing limit expression pathOFFSET ... ROWSand FETCH into one logicalLimitPerformance
FETCH produces the same logical and physical limit plans as LIMIT.
ORDER BY ... FETCHremains eligible for DataFusion's bounded Top-K optimization. The implementation adds no per-row conversion or custom execution operator.Validation
cargo +1.95.0 test -p datafusion-sql --test sql_integration(604 passed)errors.slt:78passedcargo +1.95.0 clippy -p datafusion-sql --all-targets -- -D warningscargo +1.95.0 fmt --all -- --checkgit diff --checkThe complete fork-specific
errors.sltcurrently has two unrelated pre-existing failures (CAST(c1 AS INT)and a constant-folded division-by-zero case); the changed FETCH record passes when selected directly.