Skip to content

Allow array_reduce accumulator recovery after NULL #113

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
osipovartem merged 2 commits into from
Sep 24, 2026
+34 −5
Merged

Allow array_reduce accumulator recovery after NULL #113

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
25a9b33
Allow array_reduce accumulator to recover from NULL
osipovartem Sep 24, 2026
aabecd0
Cover null element and captured-column recovery
osipovartem Sep 24, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 2 additions & 3 deletions datafusion/functions-nested/src/array_reduce.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -271,9 +271,8 @@ impl HigherOrderUDFImpl for ArrayReduce {
let mut scatter_indices = Vec::with_capacity(list.len());

for row in 0..list.len() {
let active = accumulator.is_valid(row)
&& list.is_valid(row)
&& position < offsets[row + 1] - offsets[row];
let active =
list.is_valid(row) && position < offsets[row + 1] - offsets[row];
if active {
source_indices.push(u64::try_from(offsets[row] + position).map_err(
|error| internal_datafusion_err!("invalid list index: {error}"),
Expand Down
34 changes: 32 additions & 2 deletions datafusion/sqllogictest/test_files/array/array_reduce.slt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -62,15 +62,25 @@ SELECT array_reduce([1, NULL, 2], 0, (acc, value) -> acc + coalesce(value, 0));
----
3

# A null merge result is terminal and cannot be recovered by a later element.
# A later element may recover a null accumulator.
query I
SELECT array_reduce(
[1, 2],
0,
(acc, value) -> CASE WHEN value = 1 THEN NULL ELSE coalesce(acc, 0) + value END
);
----
NULL
2

query I
SELECT array_reduce([1, 2], NULL::BIGINT, (acc, value) -> coalesce(acc, 0) + value);
----
3

query I
SELECT array_reduce([1, NULL, 2], 0, (acc, value) -> coalesce(acc, 0) + value);
----
2

query R
SELECT array_reduce([1.2, 2.3], 0, (acc, value) -> acc + value);
Expand All @@ -94,5 +104,25 @@ FROM reduce_t;
7
NULL

query I rowsort
SELECT array_reduce(values, initial,
(acc, value) -> CASE WHEN value = 1 THEN NULL ELSE coalesce(acc, 0) + value END)
FROM reduce_t;
----
5
7
9
NULL

query I rowsort
SELECT array_reduce(values, initial,
(acc, value) -> CASE WHEN value = 1 THEN NULL ELSE coalesce(acc, 0) + value + extra END)
FROM reduce_t;
----
25
29
7
NULL

statement ok
set datafusion.sql_parser.dialect = generic;
Loading