Bugfixes & Features - #462
Open
dyphire wants to merge 275 commits into
Open
Conversation
Extract shared fixture-loading scaffolding (TestHelper, HTMLFilename, TestError) and the HTML/jpg fixtures into a new TestingSupport library target, kept out of the package's public products via an isTestSupport flag on Module. Both new test targets depend on it; download tests reach the fixtures through the public TestFixtures accessor since their own Bundle.module no longer carries the resources. Drop dead TestBundleLocator and unused imports from the moved helpers. Repoint the FeatureTests.xctestplan at the two new targets.
testCancelledProcessCleanupDoesNotClearNewerActiveTask waited for the paused task's active-slot clear by polling testingActiveGalleryID against a 1-second wall-clock deadline, which intermittently failed under parallel test load (executor starvation). Replace the poll with a cancellation-event handshake: the gate's first download now parks inside withTaskCancellationHandler and signals waitForFirstCancellation() the moment pause() cancels it. Actor mutual exclusion then guarantees the active slot is already cleared before the next scheduleNextIfNeeded() runs, with no timing dependency. The first download still stays parked past cancellation so its late cleanup fires only after the second task is active — preserving the generation-guard behaviour under test. Verified: 40 run-tests-until-failure iterations, all green.
dyphire
force-pushed
the
feat
branch
2 times, most recently
from
August 13, 2026 08:51
9204198 to
3831af5
Compare
…ntaining webtoon tags
dyphire
force-pushed
the
feat
branch
11 times, most recently
from
August 16, 2026 02:05
26e7cc0 to
eb8407c
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.