Skip to content

Fix extension of conf.yaml file#433

Merged
LisaBock merged 1 commit into
mainfrom
432-esgf-intake-config-filename
May 21, 2026
Merged

Fix extension of conf.yaml file#433
LisaBock merged 1 commit into
mainfrom
432-esgf-intake-config-filename

Conversation

@alistairsellar
Copy link
Copy Markdown
Contributor

@alistairsellar alistairsellar commented May 18, 2026

Pull Request checklist

We appreciate your time and effort to improve the tutorial. Please keep in mind that lesson maintainers are volunteers and it may be some time before they can respond to your contribution.


Before you start

  • Read CONTRIBUTING.md.
  • Create an issue to discuss your idea. This allows your contributions to be incorporated into the tutorial.

Tasks

  • Give this pull request a descriptive title.
  • If you are contributing to existing lesson materials, please make sure the content conforms to the Lesson development section in CONTRIBUTING.md and does not contain any spelling or grammatical errors.
  • If you are making a new episode, please make sure the content conforms to the Lesson organization and Lesson formatting sections in CONTRIBUTING.md and does not contain any spelling or grammatical errors. N/A
  • Preferably Codacy checks pass. Status can be seen below your pull request. If there is an error, click the link to find out why.
  • Preview changes on your machine before pushing them to GitHub by running make serve, alternatively make docker-serve. Please see the Previewing your changes locally section in CONTRIBUTING.md for installation instructions.
    • I'm afraid I'm afraid I couldn't get the Ruby install working so haven't built the tutorial locally, but hopefully that's not needed since I'm only adding two characters?
  • All code instructions have been tested.

If you need help with any of the tasks above, please do not hesitate to ask by commenting in the issue or pull request.


Closes #432

@alistairsellar alistairsellar linked an issue May 18, 2026 that may be closed by this pull request
@alistairsellar
Copy link
Copy Markdown
Contributor Author

@LisaBock I think I've found a small error in the configuration episode. Would you be the right person to review this?

@LisaBock
Copy link
Copy Markdown
Member

LisaBock commented May 19, 2026

@alistairsellar Why do you think it's incorrect? Both endings yml and yaml could be used. And all configuration files in ESMValCore end with yml. So this is consistent.

@alistairsellar
Copy link
Copy Markdown
Contributor Author

@alistairsellar Why do you think it's incorrect? Both endings yml and yaml could be used. And all configuration files in ESMValCore end with yml. So this is consistent.

Hi Lisa, as far as I can tell, intake-esgf uses a different convention from ESMValCore. I've put some more detail in the issue to explain my diagnosis of the problem.

Copy link
Copy Markdown
Member

@LisaBock LisaBock left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @alistairsellar for spotting this!

@LisaBock LisaBock merged commit 9d288a6 into main May 21, 2026
2 checks passed
@LisaBock LisaBock deleted the 432-esgf-intake-config-filename branch May 21, 2026 08:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Incorrect esgf-intake config filename

2 participants