Fix getItem/setItem/clear edge cases with falsy and empty-string values#30
Open
mc21fly wants to merge 1 commit into
Open
Fix getItem/setItem/clear edge cases with falsy and empty-string values#30mc21fly wants to merge 1 commit into
mc21fly wants to merge 1 commit into
Conversation
- getItem no longer returns null for a legitimately stored empty string - setItem now coerces values to string, matching real Storage API behavior - clear() no longer stops early when a key is an empty string
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Three edge cases where MemoryStorage's behavior diverges from the real
Web Storage API:
getItem()returnsnullfor a stored empty string (""), eventhough the key genuinely exists. Real
localStorage.getItem()returns
nullonly when the key doesn't exist at all.setItem()doesn't coerce values to strings. ReallocalStoragealways stores/returns strings, even if you pass a number or other type.
clear()uses a loop that terminates early if any key happens to bean empty string, since
""is falsy in the loop'skey=keys[i]condition.Fix
Minimal, targeted changes to
getItem,setItem, andclearinsrc/memorystorage.js, plus regression tests covering all three cases.Testing
All existing tests still pass; added 3 new tests specifically covering
these edge cases.