Skip to content

fix(xqt): handle normalized notifications and device follows - #2369

Merged
Tlaster merged 1 commit into
masterfrom
bugfix/xqt-notification-device-follow
Aug 2, 2026
Merged

fix(xqt): handle normalized notifications and device follows#2369
Tlaster merged 1 commit into
masterfrom
bugfix/xqt-notification-device-follow

Conversation

@Tlaster

@Tlaster Tlaster commented Aug 1, 2026

Copy link
Copy Markdown
Contributor

No description provided.

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: e55096a29c

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

count = pageSize,
cursor = cursor,
).encodeJson(),
).body()

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2 Badge Reject failed notification responses before clearing cache

When the GraphQL request returns a non-success HTTP response (for example, an expired session, rate limiting, or a server error), Ktorfit's Response.body() is null, so this chain converts the failure into empty instructions. The refresh then invokes onClearMarker() and returns an apparently successful empty page; TimelineRemoteMediator.onSaveCache() consequently deletes the cached notification timeline. Check isSuccessful or otherwise propagate the response error before treating a missing body as an empty timeline.

Useful? React with 👍 / 👎.

@Tlaster
Tlaster merged commit 3aa7c92 into master Aug 2, 2026
9 checks passed
@Tlaster
Tlaster deleted the bugfix/xqt-notification-device-follow branch August 2, 2026 04:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant