fix(xqt): handle normalized notifications and device follows - #2369
Conversation
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: e55096a29c
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| count = pageSize, | ||
| cursor = cursor, | ||
| ).encodeJson(), | ||
| ).body() |
There was a problem hiding this comment.
Reject failed notification responses before clearing cache
When the GraphQL request returns a non-success HTTP response (for example, an expired session, rate limiting, or a server error), Ktorfit's Response.body() is null, so this chain converts the failure into empty instructions. The refresh then invokes onClearMarker() and returns an apparently successful empty page; TimelineRemoteMediator.onSaveCache() consequently deletes the cached notification timeline. Check isSuccessful or otherwise propagate the response error before treating a missing body as an empty timeline.
Useful? React with 👍 / 👎.
No description provided.