Separated PV Status Generation from Builder.py#227
Open
adedamola-sode wants to merge 7 commits into
Open
Conversation
adedamola-sode
changed the title
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #227 +/- ##
==========================================
+ Coverage 95.97% 96.09% +0.12%
==========================================
Files 11 12 +1
Lines 895 923 +28
==========================================
+ Hits 859 887 +28
Misses 36 36 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
adedamola-sode
force-pushed
the
separate-status-pv
branch
from
b2c3722 to
7c6279b
Compare
adedamola-sode
force-pushed
the
separate-status-pv
branch
from
2f5976a to
32c5815
Compare
OCopping
requested changes
Jun 2, 2026
| mock_create.return_value = Mock() | ||
| mock_write.return_value = Mock() | ||
| status_run(Path("tests/t01-services/synoptic/techui.yaml").absolute()) | ||
|
|
Collaborator
There was a problem hiding this comment.
Can you add an assert statement here please? Can just be something like assert_called() on one or both of the Mocks
Collaborator
|
Also could you please commit the generated |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.