Moved generate_json_map to new module#226
Open
adedamola-sode wants to merge 15 commits into
Open
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #226 +/- ##
==========================================
+ Coverage 95.97% 96.11% +0.13%
==========================================
Files 11 12 +1
Lines 895 927 +32
==========================================
+ Hits 859 891 +32
Misses 36 36 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
1343d80 to
1ccf832
Compare
1ccf832 to
cebc3e8
Compare
OCopping
requested changes
May 28, 2026
ef34452 to
2965c4d
Compare
checking if techui defaults to value Co-authored-by: Ollie Copping <oliver.copping@diamond.ac.uk>
606f6f7 to
c5002a6
Compare
OCopping
reviewed
Jun 2, 2026
OCopping
requested changes
Jun 2, 2026
|
|
||
|
|
||
| app = typer.Typer() | ||
| app = typer.Typer(context_settings={"allow_interspersed_args": True}) |
Collaborator
There was a problem hiding this comment.
This actually breaks using options such as --help and --log-level for the sub-apps, so we will have to remove this from the main app and add it to the sub apps individually
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Moved generate_json_map to new module called generate_jsonmap.