Skip to content

fix ci release pipeline#276

Merged
ZohebShaikh merged 1 commit into
mainfrom
fix-ci
Jun 2, 2026
Merged

fix ci release pipeline#276
ZohebShaikh merged 1 commit into
mainfrom
fix-ci

Conversation

@ZohebShaikh
Copy link
Copy Markdown
Contributor

@ZohebShaikh ZohebShaikh commented Jun 2, 2026

I wasn't able to test this on my fork CI but it does look like the right quotes to me

@ZohebShaikh ZohebShaikh requested a review from tpoliaw June 2, 2026 09:58
@ZohebShaikh ZohebShaikh enabled auto-merge June 2, 2026 10:01
@codecov
Copy link
Copy Markdown

codecov Bot commented Jun 2, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 76.44%. Comparing base (20c4fc8) to head (42b737e).

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #276   +/-   ##
=======================================
  Coverage   76.44%   76.44%           
=======================================
  Files          13       13           
  Lines        1944     1944           
=======================================
  Hits         1486     1486           
  Misses        458      458           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@ZohebShaikh ZohebShaikh added this pull request to the merge queue Jun 2, 2026
@ZohebShaikh ZohebShaikh removed this pull request from the merge queue due to a manual request Jun 2, 2026
Copy link
Copy Markdown
Collaborator

@tpoliaw tpoliaw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works running the command locally

@ZohebShaikh ZohebShaikh added this pull request to the merge queue Jun 2, 2026
Merged via the queue into main with commit 4c5ced8 Jun 2, 2026
7 checks passed
@ZohebShaikh ZohebShaikh deleted the fix-ci branch June 2, 2026 11:12
@ZohebShaikh
Copy link
Copy Markdown
Contributor Author

@tpoliaw There should be a requirement to get at-least one approval before merge.
As it currently stand it can be merged without any approval if the CI passes

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants