Fix release CI payload isolation, ConPTY starvation, and signed NuGet payloads - #49
Merged
Marc-André Moreau (mamoreau-devolutions) merged 4 commits intoSep 30, 2026
Conversation
Exclude Windows ConPTY hosts at the final Unix publish boundary, validate nested macOS code, and exercise the release signer on both actual NativeAOT bundles in ordinary CI without credentials. Preserve uploaded payloads and checksums. Use cancellable asynchronous host-side pipes and registered process-exit waits so idle sessions and blocked input cannot exhaust the worker pool. Add an isolated constrained-worker regression verified to fail against the old implementation. Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Route NuGet packaging through the Windows MSI signing layouts and standalone Developer ID-signed macOS payloads. Preserve the flat runtime contract by signing macOS native code outside the app bundle with runtime entitlements. Gate publication on signatures verified from actual restored/extracted nupkgs; fail instead of falling back to unsigned release code. Keep ordinary CI and unsigned dry runs credential-free, exclude native debug symbols, and validate both Windows signature failures and macOS standalone layout behavior. Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
macOS26 system tools are universal x86_64/arm64e, not arm64. Compile the tiny fixture for the actual test RID instead of accepting the wrong architecture or weakening payload validation. Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Recent codesign versions default to a human-readable dictionary dump. Ask for XML explicitly so the native NuGet signature gate can validate required entitlements without loosening its assertions. Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Marc-André Moreau (mamoreau-devolutions)
requested a review
from a team
as a code owner
September 30, 2026 20:14
Marc-André Moreau (mamoreau-devolutions)
merged commit Sep 30, 2026
e617dcd
into
master
27 checks passed
Marc-André Moreau (mamoreau-devolutions)
deleted the
copilot/release-ci-repair
branch
September 30, 2026 20:16
Marc-André Moreau (mamoreau-devolutions)
deployed
to
publish-dry-run
September 30, 2026 20:18 — with 
GitHub Actions
Active
GitHub Actions
Active
Marc-André Moreau (mamoreau-devolutions)
deployed
to
publish-dry-run
September 30, 2026 20:18 — with
GitHub Actions
Active
GitHub Actions
Active
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
The release workflow kept failing in the same two places across several attempted fixes:
While verifying the fix, a third issue surfaced: release NuGet packages shipped unsigned native payloads even though the MSI/macOS signing jobs had produced signed binaries.
Changes
ConPtySchedulingTests).Test-WindowsPayloadSignatures.ps1plus regression coverage, and native macOS NuGet signature/layout gates that inspect the actual.nupkgcontents..pdb/.dbg/.dSYM) excluded.Validation
422a6f9, including both native macOS NuGet signature jobs.Follow-up
This run was credential-free. A
prodsigned dry run is still needed to exercise the protected signing path end to end.Co-authored-by: Copilot App 223556219+Copilot@users.noreply.github.com