refactor: set log level explicitly instead of mutating RUST_LOG - #492
Merged
Conversation
std::env::set_var is unsafe in Rust 2024 and mutating a process-wide env var before pretty_env_logger reads it is a footgun. Build the logger via formatted_builder() instead: parse RUST_LOG when set (preserving its precedence) and otherwise default to the info level when --verbose is passed. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_016LhirbVDPWoicNDeB5paDy
Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_016LhirbVDPWoicNDeB5paDy
DeveloperC286
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
std::env::set_var is unsafe in Rust 2024 and mutating a process-wide env
var before pretty_env_logger reads it is a footgun. Build the logger via
formatted_builder() instead.