Skip to content

Fix missing flake input in README - #199

Merged
lucperkins merged 1 commit into
mainfrom
add-determinate-flake-input-in-readme
Aug 20, 2026
Merged

Fix missing flake input in README#199
lucperkins merged 1 commit into
mainfrom
add-determinate-flake-input-in-readme

Conversation

@lucperkins

@lucperkins lucperkins commented Aug 20, 2026

Copy link
Copy Markdown
Member

The nix-darwin example uses inputs.determinate but doesn't add determinate to the flake inputs.

Summary by CodeRabbit

  • Documentation
    • Updated the nix-darwin configuration example to use version 3 of the Determinate flake input.

@coderabbitai

coderabbitai Bot commented Aug 20, 2026

Copy link
Copy Markdown

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: 87548bcc-bfae-499f-86c7-1a228ee063dc

📥 Commits

Reviewing files that changed from the base of the PR and between 6069a65 and 7c6d3a6.

📒 Files selected for processing (1)
  • README.md

Included review availability: 4 reviews are currently available. Your included PR review attempts over the past 7 days set your current allowance at 5 reviews per hour.


📝 Walkthrough

Walkthrough

The nix-darwin configuration example in README.md now declares the determinate flake input from the FlakeHub version 3 URL.

Changes

nix-darwin Example

Layer / File(s) Summary
Update determinate flake input
README.md
The nix-darwin example adds the determinate flake input with the FlakeHub version 3 URL.

Estimated code review effort: 1 (Trivial) | ~2 minutes

Merge Risk: ⚪ Minimal · up to 7c6d3

This is a localized README fix that makes the documented flake inputs consistent with the example usage; no actionable merge-blocking risk remains beyond normal checks and review.

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly and concisely describes the README change that adds the missing flake input.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch add-determinate-flake-input-in-readme

Comment @coderabbitai help to get the list of available commands.

Comment thread README.md
determinate.url = "https://flakehub.com/f/DeterminateSystems/determinate/3";
};

outputs = { self, ... }@inputs: {

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

personally, I'd yoink the { self, ...}@ bit and just leave it as inputs. I really don't like the destructing here and try to undo it anywhere I see it.

(Also avoids the issue where nix will populate those destructured fields from the registry if they're not in the inputs [we warn, but still...])

totally a nit though

@lucperkins
lucperkins merged commit e174ad0 into main Aug 20, 2026
9 checks passed
@lucperkins
lucperkins deleted the add-determinate-flake-input-in-readme branch August 20, 2026 16:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants