Enable APIsec telemetry test for Node.js#7145
Conversation
🎉 All green!🧪 All tests passed 🔗 Commit SHA: 18600c1 | Docs | Datadog PR Page | Give us feedback! |
|
|
There was a problem hiding this comment.
When a request is blocked early (during incomingHttpRequestStart, before framework middleware runs), the span's component tag is still http (the framework-specific value never gets set).
For that reason the test accepts both the framework name and http as valid framework tags: the former for normal requests, the latter for early-blocked ones.
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 18600c15c5
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
Motivation
Enable APISec telemetry test for Node.js
Changes
Workflow
🚀 Once your PR is reviewed and the CI green, you can merge it!
🛟 #apm-shared-testing 🛟
Reviewer checklist
tests/ormanifests/is modified ? I have the approval from R&P teambuild-XXX-imagelabel is present