Skip to content

Enable APIsec telemetry test for Node.js#7145

Merged
CarlesDD merged 9 commits into
mainfrom
ccapell/APPSEC-62704/nodejs-api-sec-metrics
Jun 25, 2026
Merged

Enable APIsec telemetry test for Node.js#7145
CarlesDD merged 9 commits into
mainfrom
ccapell/APPSEC-62704/nodejs-api-sec-metrics

Conversation

@CarlesDD

Copy link
Copy Markdown
Contributor

Motivation

Enable APISec telemetry test for Node.js

Changes

  • Changed Node.js manifest to enable these tests
  • Adapt the test to expect more than one framework on the reported metrics

Workflow

  1. ⚠️ Create your PR as draft ⚠️
  2. Work on you PR until the CI passes
  3. Mark it as ready for review
    • Test logic is modified? -> Get a review from RFC owner.
    • Framework is modified, or non obvious usage of it -> get a review from R&P team

🚀 Once your PR is reviewed and the CI green, you can merge it!

🛟 #apm-shared-testing 🛟

Reviewer checklist

  • Anything but tests/ or manifests/ is modified ? I have the approval from R&P team
  • A docker base image is modified?
    • the relevant build-XXX-image label is present
  • A scenario is added, removed or renamed?

@datadog-prod-us1-3

datadog-prod-us1-3 Bot commented Jun 16, 2026

Copy link
Copy Markdown
Contributor

Tests

🎉 All green!

🧪 All tests passed
❄️ No new flaky tests detected

This comment will be updated automatically if new data arrives.
🔗 Commit SHA: 18600c1 | Docs | Datadog PR Page | Give us feedback!

@github-actions

Copy link
Copy Markdown
Contributor

CODEOWNERS have been resolved as:

manifests/nodejs.yml                                                    @DataDog/dd-trace-js
tests/appsec/api_security/test_apisecurity_telemetry.py                 @DataDog/asm-libraries @DataDog/system-tests-core

@CarlesDD CarlesDD changed the title [nodejs@ccapell/APPSEC-62704/api-sec-metrics] Enable APIsec telemetry test [nodejs] Enable APIsec telemetry test Jun 16, 2026
@CarlesDD CarlesDD changed the title [nodejs] Enable APIsec telemetry test Enable APIsec telemetry test Jun 16, 2026

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

When a request is blocked early (during incomingHttpRequestStart, before framework middleware runs), the span's component tag is still http (the framework-specific value never gets set).
For that reason the test accepts both the framework name and http as valid framework tags: the former for normal requests, the latter for early-blocked ones.

@CarlesDD CarlesDD changed the title Enable APIsec telemetry test Enable APIsec telemetry test for Node.js Jun 25, 2026
@CarlesDD CarlesDD marked this pull request as ready for review June 25, 2026 14:55
@CarlesDD CarlesDD requested review from a team as code owners June 25, 2026 14:55

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 18600c15c5

ℹ️ About Codex in GitHub

Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".

Comment thread tests/appsec/api_security/test_apisecurity_telemetry.py
@CarlesDD CarlesDD merged commit 7f37103 into main Jun 25, 2026
427 checks passed
@CarlesDD CarlesDD deleted the ccapell/APPSEC-62704/nodejs-api-sec-metrics branch June 25, 2026 15:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants