fix(deps): vuln protobuf (major → 7.35.1) [apps/rpc/python] - #320
Conversation
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 1e7325c55a
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
| grpcio-tools==1.59.0 # Proto compiler for Python | ||
| ddtrace==4.12.2 # Datadog APM tracing library | ||
| protobuf==4.25.8 # Protocol Buffers runtime | ||
| protobuf==7.35.1 # Protocol Buffers runtime |
There was a problem hiding this comment.
Keep protobuf compatible with grpcio-tools
grpcio-tools==1.59.0 declares protobuf>=4.21.6,<5.0dev, so pinning protobuf 7.35.1 creates an unsatisfiable dependency set. The pip install -r requirements.txt step in this example's Dockerfile will terminate with ResolutionImpossible, preventing both service images from building; upgrade grpcio-tools to a version supporting protobuf 7 or select a fixed protobuf release within its supported range.
Useful? React with 👍 / 👎.
Auto-rebase completeBranch is up to date with Auto-Rebase · Add |
1e7325c to
ebcc2a5
Compare
Co-authored-by: dd-octo-sts-09fbc5[bot] <256648608+dd-octo-sts-09fbc5[bot]@users.noreply.github.com>
ebcc2a5 to
039c2ba
Compare
Summary: High-severity security update — 1 package upgraded (MAJOR changes included)
Manifests changed:
apps/rpc/python(pip)✅ Action Required: Please review the changes below. If they look good, approve and merge this PR.
Updates
Warning
Major Version Upgrade
This update includes major version changes that may contain breaking changes. Please:
Security Details
🚨 Critical & High Severity (3 fixed)
Review Checklist
Extra review is recommended for this update:
Update Mode: all_vulns
🤖 Generated by DataDog Automated Dependency Management System