feat(remote-config)!: agentless RC fetcher#2112
Open
paullegranddc wants to merge 17 commits into
Open
Conversation
Contributor
|
Contributor
📚 Documentation Check Results📦
|
Contributor
Clippy Allow Annotation ReportComparing clippy allow annotations between branches:
Summary by Rule
Annotation Counts by File
Annotation Stats by Crate
About This ReportThis report tracks Clippy allow annotations for specific rules, showing how they've changed in this PR. Decreasing the number of these annotations generally improves code quality. |
Contributor
🔒 Cargo Deny Results📦
|
| // TODO: We do not store the delegated targets metadata | ||
| // This will need to be revisited in order to support proper Uptane | ||
| // verification of the full configuration data. | ||
| // store(repo, &targets_path, &metas.delegated_targets).await?; |
Member
There was a problem hiding this comment.
I think you can safely skip them, director repo already confirms it's from datadog, for your account, integrity checks and the routing predicate. What it does not confirm is the product behind the config
paullegranddc
changed the title
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: f71677404b
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| .uri(url_with_path(self.endpoint.url.clone(), path)?) | ||
| .method(method) | ||
| .body(body)?; | ||
| Ok(self.http.request(req).await?) |
There was a problem hiding this comment.
When agentless mode is pointed at a slow or unresponsive RC backend, this await is not bounded by Endpoint::timeout_ms. The agent path wraps its HTTP request in tokio::time::timeout(...), and NativeHttpClient only awaits hyper and body collection, so a stalled request can keep fetch_once and the SharedFetcher run loop stuck indefinitely instead of allowing cancellation or later polls. Wrap this request with the endpoint timeout before awaiting it.
Useful? React with 👍 / 👎.
| self.config_client.update().await?; | ||
| self.director_client.update().await?; | ||
|
|
||
| let targets: Vec<TrustedTarget<'_>> = trusted_targets(&self.director_client)?.collect(); |
There was a problem hiding this comment.
When the backend returns delegated config targets, this code discards config_metas.delegated_targets and then builds the active target set exclusively from the director repository. In a buggy or compromised online director/backend scenario, a target whose path/hash is valid in director metadata but missing or different in the config repository is still fetched and cached, so the offline config repository no longer authorizes the bytes. Store/refresh delegated config metadata and verify each director target against the config repo before returning it.
Useful? React with 👍 / 👎.
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: f71677404b
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| .uri(url_with_path(self.endpoint.url.clone(), path)?) | ||
| .method(method) | ||
| .body(body)?; | ||
| Ok(self.http.request(req).await?) |
There was a problem hiding this comment.
When agentless mode is pointed at a slow or unresponsive RC backend, this await is not bounded by Endpoint::timeout_ms. The agent path wraps its HTTP request in tokio::time::timeout(...), and NativeHttpClient only awaits hyper and body collection, so a stalled request can keep fetch_once and the SharedFetcher run loop stuck indefinitely instead of allowing cancellation or later polls. Wrap this request with the endpoint timeout before awaiting it.
Useful? React with 👍 / 👎.
| self.config_client.update().await?; | ||
| self.director_client.update().await?; | ||
|
|
||
| let targets: Vec<TrustedTarget<'_>> = trusted_targets(&self.director_client)?.collect(); |
There was a problem hiding this comment.
When the backend returns delegated config targets, this code discards config_metas.delegated_targets and then builds the active target set exclusively from the director repository. In a buggy or compromised online director/backend scenario, a target whose path/hash is valid in director metadata but missing or different in the config repository is still fetched and cached, so the offline config repository no longer authorizes the bytes. Store/refresh delegated config metadata and verify each director target against the config repo before returning it.
Useful? React with 👍 / 👎.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
In some environments (serverless, Datadog studio), tracers can't rely on a Datadog Agent to proxy Remote Config requests. This PR adds an agentless mode to libdd-remote-config so the fetcher can talk directly to the RC backend, mirroring what the Go agent does today.
The protocol is different from the agent's /v0.7/config: the backend speaks protobuf and ships raw TUF metadata + target files that the client must verify locally. This means embedding TUF trust roots per site and running a full Uptane-style validation on every poll.
Changes
How to test the change?
Also this has been tested in dd-trace-rs
DataDog/dd-trace-rs#263