Skip to content

feat: add FirebirdSQL dialect support - #109

Open
alexeykovyazin wants to merge 1 commit into
DataDog:mainfrom
alexeykovyazin:main
Open

feat: add FirebirdSQL dialect support#109
alexeykovyazin wants to merge 1 commit into
DataDog:mainfrom
alexeykovyazin:main

Conversation

@alexeykovyazin

Copy link
Copy Markdown
  • new firebird DBMS (alias firebirdsql): ANSI string literals with '' quote doubling, :name bind parameters, $ restricted to identifiers (RDB$...), Firebird keywords (RECREATE, SUSPEND, STARTING, CONTAINING, SIMILAR, SINGULAR, LEAVE)
  • complete ANSI quote-doubling for SQL Server and Oracle strings (follow-up to fix(lexer): don't treat backslash as string escape in SQL Server and Oracle #103): 'don''t' is a single literal, dynamic SQL such as N'... = ''' + @x + ''' ...' no longer mis-lexes
  • fix bind parameter scanning for multi-byte names (:größe, :šablon, :имя)
  • fix embed.FS path handling in dbms_test.go so the suite runs on Windows
  • testdata/firebird (19 cases grounded in the EMPLOYEE schema) and testdata/firebird/unicode (RU / SR-Cyrl / SR-Lat / PT / ES / DE) suites, lexer and normalizer unit tests; dialect behavior validated against a live Firebird 5.0.3 server
  • docs: README updates, FIREBIRD.md design and validation write-up, CHANGELOG

- new `firebird` DBMS (alias `firebirdsql`): ANSI string literals with ''
  quote doubling, :name bind parameters, $ restricted to identifiers
  (RDB$...), Firebird keywords (RECREATE, SUSPEND, STARTING, CONTAINING,
  SIMILAR, SINGULAR, LEAVE)
- complete ANSI quote-doubling for SQL Server and Oracle strings
  (follow-up to DataDog#103): 'don''t' is a single literal, dynamic SQL such as
  N'... = ''' + @x + ''' ...' no longer mis-lexes
- fix bind parameter scanning for multi-byte names (:größe, :šablon, :имя)
- fix embed.FS path handling in dbms_test.go so the suite runs on Windows
- testdata/firebird (19 cases grounded in the EMPLOYEE schema) and
  testdata/firebird/unicode (RU / SR-Cyrl / SR-Lat / PT / ES / DE) suites,
  lexer and normalizer unit tests; dialect behavior validated against a
  live Firebird 5.0.3 server
- docs: README updates, FIREBIRD.md design and validation write-up, CHANGELOG
@alexeykovyazin
alexeykovyazin requested a review from a team as a code owner August 27, 2026 17:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant