Skip to content

[PANA-9470] Increase Session Replay batch expiration - #3981

Merged
gonzalezreal merged 1 commit into
developfrom
gonzalezreal/PANA-9470/session-replay-batch-expiration
Oct 14, 2026
Merged

gonzalezreal merged 1 commit into
developfrom
gonzalezreal/PANA-9470/session-replay-batch-expiration

Conversation

@gonzalezreal

Copy link
Copy Markdown
Contributor

What does this PR do?

Increase segment batch expiration from 5 to 12 hours and resource batch expiration from 18 to 48 hours.

Motivation

Give pending uploads more time after connectivity returns, matching DataDog/dd-sdk-ios#3298

Review checklist (to be filled by reviewers)

  • Feature or bugfix MUST have appropriate tests (unit, integration, e2e)
  • Make sure you discussed the feature or bugfix with the maintaining team in an Issue
  • Make sure each commit and the PR mention the Issue number (cf the CONTRIBUTING doc)

@gonzalezreal
gonzalezreal requested review from a team as code owners October 13, 2026 15:22
@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Oct 13, 2026 •

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-10-13T15:24:49.489917Z af0f0bc PR opened
🔒 Security Review ✅ Completed 2026-10-13T15:29:31.773397Z af0f0bc PR opened
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@datadog-prod-us1-5

datadog-prod-us1-5 Bot commented Oct 13, 2026 •

Copy link
Copy Markdown

Tests

✅ All CI checks and tests passed. Datadog automation helped this PR pass.

🎉 All green!

🧪 All tests passed
❄️ No new flaky tests detected

🔄 Datadog retried 1 test - 1 passed on retry View in Datadog

🎯 Code Coverage (details)
• Patch Coverage: 100.00%
• Overall Coverage: 71.76% (-0.01%)

This comment will be updated automatically if new data arrives.
🔗 Commit SHA: af0f0bc | Docs | View more details | Give us feedback!

@datadog-prod-us1-5 datadog-prod-us1-5 Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Bits Code Review: PASS

More details

The 12-hour segment and 48-hour resource thresholds reach storage cleanup without conflicting expiration limits, preserving pending batches longer for upload after connectivity returns.

Was this helpful? React 👍 or 👎

Open Bits AI session

🤖 Bits Code Review · Commit af0f0bc

@gonzalezreal
gonzalezreal merged commit cb96e73 into develop Oct 14, 2026
26 checks passed
@gonzalezreal
gonzalezreal deleted the gonzalezreal/PANA-9470/session-replay-batch-expiration branch October 14, 2026 07:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants