Repository navigation
Conversation
|
✅ All CI checks and tests passed. Datadog automation helped this PR pass. 🎉 All green!🧪 All tests passed 🔄 Datadog retried 1 test - 1 passed on retry 🎯 Code Coverage (details) 🔗 Commit SHA: 2b391e8 | Docs | View more details | Give us feedback! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Two related fixes to RUM slow-frame tracking:
DefaultSlowFramesListenernow measures the gap between consecutive slow frames from the end of the previous record (start + duration) instead of its start, so genuinely back-to-back slow frames are correctly merged into a single record instead of incorrectly starting a new one.diffViewEvent'sdiffSlowFramesnow resends the last known slow-frame record in a view update whenever itsdurationhas changed, not just when a newer record with a laterstartappears — fixing a case where a growing record's duration correction was silently dropped from the diff after its first transmission.Motivation
The two bugs compound each other: the first makes slow frames merge far more often once fixed, which increases exposure to the second.
Additional Notes
DefaultSlowFramesListenerTest("separate janks") where the listener was built with a hardcodedcontinuousSlowFrameThresholdNs = 16instead of the test's own forged parameter.Review checklist (to be filled by reviewers)