Repository navigation
Conversation
Bundles Sizes Evolution
|
|
✅ All CI checks and tests passed. 🎉 All green!🧪 All tests passed 🎯 Code Coverage (details) 🔗 Commit SHA: 8aa6825 | Docs | View more details | Give us feedback! |
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
![datadog-official[bot]](https://avatars.githubusercontent.com/in/1358509?s=60&v=4){kind=small}
There was a problem hiding this comment.
More details
The test guidance matches the repository’s build prerequisites and setup selection. The gitmoji guidance correctly classifies removal of a deprecated public API as a breaking change.
🤖 Bits Code Review · Commit 8aa6825
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 8aa68253aa
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| | Mistake | Fix | | ||
| | ----------------------------------------------------------------------------- | ----------------------------------------------------------------------------------------------------------------------------- | | ||
| | Running `npmSetup`/app-based E2E or perf tests right after editing SDK source | `yarn build:apps` first, otherwise they use stale packages | | ||
| | E2E passes locally, fails in CI on `<test> > npm` | Locally only `bundle` runs. `yarn build:apps`, then `CI=1 yarn test:e2e -g "<test>"` runs `async`, `npm` and `bundle` like CI | |
There was a problem hiding this comment.
issue: For failures from any Firefox, WebKit, or pinned-browser CI job, this command silently runs Chromium because test/e2e/playwright.config.ts registers only the Chromium project when no --project argument is provided, while the e2e matrix in .gitlab-ci.yml explicitly invokes --project=$BROWSER for six browsers. Instruct users to copy the failing job's browser into --project=<browser>; otherwise the prescribed command can fail to reproduce the CI-only behavior this entry is meant to diagnose.
AGENTS.md reference: AGENTS.md:L49-L49
Useful? React with 👍 / 👎.
|
|
||
| ## Signing | ||
|
|
||
| Every commit must be signed. `main` has a `required_signatures` ruleset, so a single unsigned commit blocks the merge. Check with `git log --show-signature -1`. If `git config commit.gpgsign` isn't `true`, commit with `git commit -S`. |
There was a problem hiding this comment.
issue: In a multi-commit PR where HEAD is signed but an earlier commit is unsigned, this check reports only the signed HEAD because -1 limits the log to one commit (git rev-list -h lists --max-count=<n> under “limiting output”). That contradicts the preceding requirement that one unsigned commit blocks the merge; inspect the full PR range, such as origin/main..HEAD, so contributors do not discover an older unsigned commit only at merge time.
AGENTS.md reference: AGENTS.md:L142-L142
Useful? React with 👍 / 👎.
This branch has not been deployed
1 participant
Motivation
Test commands and commit/PR rules are spread across
AGENTS.md,docs/TESTING.md,test/e2e/AGENTS.md,docs/DEVELOPMENT.md,CONTRIBUTING.mdand some CI scripts. Without these skills, an agent needed up to 11 files to answer basic questions, and it picked 🔥 instead of 💥 for removing a public API. That hides a breaking change under Internal Changes. The iOS SDK already has repo skills for this kind of thing, so I did the same here.Changes
running-testsis one table with every test command. It also explains when you actually needyarn build:apps: locally, E2E only runs thebundlesetup straight from source, butnpmSetup, app-based tests and the performance tests use built apps.writing-commits-and-prscovers signing, the PR template and how the gitmoji ends up in the changelog. It uses the list indocs/DEVELOPMENT.mdinstead of keeping its own copy, since the changelog legend is built from that file. I also clarified 🔥 there. It said "deprecated items", and #4329 and #4677 both went in as 🔥 but ended up as 💥 and ✨ in the changelog. What do you think?AGENTS.mdkeeps the commands and drops the commit/PR rules that the skill now covers. It still says titles start with a gitmoji, because a skill only loads when the agent thinks it applies, and it points to both skills with their path so agents that don't load skills automatically can still find them.I also tried a skill for the generated schema types, but agents already did the right thing without it, so I dropped it.
Both skills were written with an agent. Every command was checked against
package.json, the Karma and Playwright configs, and the CI scripts.Test instructions
I asked an agent the same questions with and without the skills. With them, it got all of them right from the skill file alone.
To try it, check out this branch and ask your agent:
writing-commits-and-prsand answer 💥send unhandled rejections > npmbut it passes locally. How do I reproduce it?"running-testsand sayyarn build:apps, thenCI=1 yarn test:e2e -g "send unhandled rejections"Checklist