Skip to content

fix undefined error when duplicates section is not present for workspace item - #6007

Merged
tdonohue merged 1 commit into
DSpace:mainfrom
tinsch:fix-duplicates-section-undefined-error
Aug 18, 2026
Merged

fix undefined error when duplicates section is not present for workspace item#6007
tdonohue merged 1 commit into
DSpace:mainfrom
tinsch:fix-duplicates-section-undefined-error

Conversation

@tinsch

@tinsch tinsch commented Jul 30, 2026

Copy link
Copy Markdown
Contributor

References

Description

Adds an additional undefined safety check for when the duplicates section is not present in the workspace item json data.

Instructions for Reviewers

  1. Have the duplicates section enabled in the submission form
  2. Have a duplicate of the item you'd like to create a new version of in a workflow state
  3. Try to create a new version of the item as an admin. Observe that you are able to create and edit the new version.

Additional tests

Check that the duplicates section still shows up for unaffected items

Checklist

This checklist provides a reminder of what we are going to look for when reviewing your PR. You do not need to complete this checklist prior creating your PR (draft PRs are always welcome).
However, reviewers may request that you complete any actions in this list if you have not done so. If you are unsure about an item in the checklist, don't hesitate to ask. We're here to help!

  • My PR is created against the main branch of code (unless it is a backport or is fixing an issue specific to an older branch).
  • My PR is small in size (e.g. less than 1,000 lines of code, not including comments & specs/tests), or I have provided reasons as to why that's not possible.
  • My PR follows all coding best practices based on the Code Conventions Guide
  • My PR passes ESLint validation using npm run lint
  • My PR doesn't introduce circular dependencies (verified via npm run check-circ-deps)
  • My PR includes TypeDoc comments for all new (or modified) public methods and classes. It also includes TypeDoc for large or complex private methods.
  • My PR passes all specs/tests and includes new/updated specs or tests based on the Code Testing Guide.
  • My PR aligns with Accessibility guidelines if it makes changes to the user interface.
  • My PR uses i18n (internationalization) keys instead of hardcoded English text, to allow for translations.
  • My PR includes details on how to test it. I've provided clear instructions to reviewers on how to successfully test this fix or feature.
  • If my PR includes new libraries/dependencies (in package.json), I've made sure their licenses align with the DSpace BSD License based on the Licensing of Contributions documentation.
  • If my PR includes new features or configurations, I've provided basic technical documentation in the PR itself.
  • If my PR fixes an issue ticket, I've linked them together.

LLM Disclosure

I used ChatGPT (Model GPT-5.5 Instant) to help me with the investigation of the bug and to help with the undefined safety check. I fully understand the code and why it fixes the bug. No LLM was used in writing the bug report and the PR text.

@tinsch tinsch added the port to dspace-9_x This PR needs to be ported to `dspace-9_x` branch for next bug-fix release label Jul 30, 2026
@lgeggleston lgeggleston added bug component: submission port to dspace-10_x This PR needs to be ported to `dspace-10_x` branch for next bug-fix release labels Jul 30, 2026
@lgeggleston lgeggleston moved this to 🙋 Needs Reviewers Assigned in DSpace 11.0 Release Jul 30, 2026
@EikLoe
EikLoe self-requested a review August 14, 2026 12:56

@EikLoe EikLoe left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @tinsch ,

Thanks for the fix. I tested it and it worked fine for me! The code looks good to me, too. So +1

@EikLoe EikLoe moved this from 🙋 Needs Reviewers Assigned to 👍 Reviewer Approved in DSpace 11.0 Release Aug 14, 2026
@tdonohue tdonohue added this to the 11.0 milestone Aug 17, 2026

@tdonohue tdonohue left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Thanks @tinsch ! This looks logically sound to me & I see that @EikLoe tested it.

@tdonohue tdonohue added the port to dspace-8_x This PR needs to be ported to `dspace-8_x` branch for next bug-fix release label Aug 18, 2026
@tdonohue
tdonohue merged commit 3d59ea3 into DSpace:main Aug 18, 2026
18 of 19 checks passed
@github-project-automation github-project-automation Bot moved this from 👍 Reviewer Approved to ✅ Done in DSpace 11.0 Release Aug 18, 2026
@dspace-bot

Copy link
Copy Markdown
Contributor

@dspace-bot

Copy link
Copy Markdown
Contributor

@dspace-bot

Copy link
Copy Markdown
Contributor

@tdonohue tdonohue removed port to dspace-8_x This PR needs to be ported to `dspace-8_x` branch for next bug-fix release port to dspace-9_x This PR needs to be ported to `dspace-9_x` branch for next bug-fix release port to dspace-10_x This PR needs to be ported to `dspace-10_x` branch for next bug-fix release labels Aug 18, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

Status: ✅ Done

Development

Successfully merging this pull request may close these issues.

Workspace item duplication check step throws error and causes problems in the frontend

5 participants