Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
promote: dev -> main (platform batch, prod incident fixes, auth UX) #56
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Uh oh!
There was an error while loading. Please reload this page.
promote: dev -> main (platform batch, prod incident fixes, auth UX) #56
Changes from all commits
a70e7544d9a0c1209d287173f9ac54837a87a891255411fe2d1086fff46220d36d984dFile filter
Filter by extension
Conversations
Uh oh!
There was an error while loading. Please reload this page.
Jump to
Uh oh!
There was an error while loading. Please reload this page.
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fetching all of a user's organizations and then filtering in memory to find their role in a specific organization can be inefficient. This could lead to performance issues for users who are members of a large number of organizations.
A more performant approach would be to add a dedicated method in
OrganizationRepositoryto fetch only the specific organization and the user's role within it.For example, a method like
findUserRoleInOrg(userId: string, organizationId: string): Promise<{ role: Role } | null>could execute a more targeted database query. Here is an example of how that might be implemented in your repository:This would significantly reduce the amount of data fetched from the database and improve the performance of this critical path.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.