chore(ci): remove one-off CodeQL dismissal workflow - #50
Merged
Merged
Conversation
GITHUB_TOKEN can read code scanning alerts but cannot dismiss them: the dismissal endpoint is restricted to user tokens for the dismissed_by audit trail and returns 404 even with security-events: write. The dismissal needs the operator user token with security_events scope instead. Alert 1567 stays open until then; the containment guard from PR #43 remains in place.
|
Note Gemini is unable to generate a review for this pull request due to the file types involved not being currently supported. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce?
CI/CD. Removes .github/workflows/oneoff-dismiss-alert.yml (added in #48/#49). Nothing else changes.
Why was this change needed?
The one-off workflow proved the point it was created for: its debug run showed GITHUB_TOKEN can read code scanning alerts but the dismissal endpoint rejects it with 404 even under security-events: write - GitHub restricts alert dismissal to user tokens for the dismissed_by audit trail. The dismissal therefore needs the operator user token with security_events scope; the temporary workflow has no further use and is removed to keep .github/workflows clean. Alert 1567 stays open with the containment guard from PR #43 in place until the operator-scope dismissal happens.
Technical Details & Scope
Verification & Testing
The run https://github.com/DOS/Crove-Post/actions/runs/35622844568 contains the debug evidence (GET succeeds, PUT 404). CI on this PR confirms nothing else breaks.
QA
Checklist: