docs(agents): extend encrypted-at-rest rule to branch names - #52
Merged
Conversation
Owner
Author
Review SummaryDirect single-pass review (docs-only, +1/−1) — no sub-agent fan-out needed. FindingsNo P1–P3 findings. The change is accurate and well-scoped:
Verification
CommitNo fix commit — nothing to fix. Verdict: approve |
GitHub keeps a PR's head branch name forever, even after the branch is deleted, so a branch name is plaintext metadata in exactly the way a commit message is — but with no after-the-fact fix. Name the constraint where the rest of the rule lives. Ported from #52, whose base predated the transcrypt -> glassine move.
DJRHails
force-pushed
the
DJRHails/encrypted-metadata-branch-names
branch
from
July 31, 2026 01:48
e3ab932 to
150850a
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The Git Hygiene rule for encrypted-at-rest files enumerates the plaintext metadata surfaces to keep generic (commit message, PR title/description, issue text, review comments) but omitted branch names. #51's head branch name embedded a detail its encrypted file exists to hide — and branch names are the one surface with no after-the-fact fix, since GitHub retains a PR's head branch name even after the branch is deleted.
This adds branch names to the enumeration and a note that they must be chosen generically before the first push.
Found during the post-merge review of #51 (run).