feat(notification): add Denario wallet branding for verification-code mail#4375
Open
joshuakrueger-dfx wants to merge 2 commits into
Open
feat(notification): add Denario wallet branding for verification-code mail#4375joshuakrueger-dfx wants to merge 2 commits into
joshuakrueger-dfx wants to merge 2 commits into
Conversation
… mail Wires the Denario partner wallet into the existing per-wallet mail branding mechanism (same mechanism as RealUnit/onchainlabs): a dedicated denario.hbs template plus English verification_code overrides, using the default DFX mail transport (no dedicated mailbox provided by Denario).
- forcedLang 'en' so Denario's branded shell never wraps DFX default- language text for non-English users - replace invalid div-in-p markup in the verification-code box with an inline-block span - give the 2FA-login and email-change verification contexts distinct, accurate copy instead of reusing "continue with your registration" for both - resolveMailWallet: order the branded-wallet lookup deterministically (most recently linked wins) now that more than one wallet can be isPreferred at once, since account merges are not wallet-restricted - update the notification-service test to match: a preferred wallet is now always configured, so the DB lookup runs
joshuakrueger-dfx
marked this pull request as ready for review
July 24, 2026 18:24
joshuakrueger-dfx
requested review from
TaprootFreak and
davidleomay
as code owners
July 24, 2026 18:24
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
denario.hbstemplate (branded header, footer) used for all future Denario transactional mailmail-denario.jsonoverride for the verification-code mail (subject, salutation, dashed-border code box, closing) — other languages fall back to DFX default textTest plan
tsc --noEmitcleaneslintclean on changed filesprettier --checkcleandenario.hbswith verification-code content and with generic url/mail affix items (future non-verification mails)