Release: develop -> main#4350
Merged
Merged
Conversation
…4349) The four pending leg fields (fromKraken/toKraken/fromScrypt/toScrypt) dropped negative values from the FinancialDataLog JSON breakdown, because getJsonValue defaults returnNegativeValue to false. Since #4348 lets the unfiltered legs net negative, a negative leg silently disappeared from the breakdown while still subtracting from totalPlusPending, so the visible components no longer summed to the total. Pass returnNegativeValue=true (matching this file's convention for plusBalanceChf/minusBalanceChf/totalBalanceChf/plusBalance/minusBalance/totalPlus/liquidity) so signed legs stay visible and the breakdown reconciles — restoring the diagnostic used to spot equity phantoms.
github-actions
Bot
requested review from
TaprootFreak and
davidleomay
as code owners
July 23, 2026 20:08
TaprootFreak
approved these changes
Jul 23, 2026
Author
ℹ️ New TODOs/FIXMEs (1)+ address: yapealEUR.bic.padEnd(11, 'XXX'), |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Automatic Release PR
This PR was automatically created after changes were pushed to develop.
Commits: 1 new commit(s)
Checklist