test(bank): gate frick-viban provider at 100% coverage#4336
Draft
joshuakrueger-dfx wants to merge 1 commit into
Draft
test(bank): gate frick-viban provider at 100% coverage#4336joshuakrueger-dfx wants to merge 1 commit into
joshuakrueger-dfx wants to merge 1 commit into
Conversation
joshuakrueger-dfx
marked this pull request as ready for review
July 23, 2026 11:48
joshuakrueger-dfx
requested review from
TaprootFreak and
davidleomay
as code owners
July 23, 2026 11:48
joshuakrueger-dfx
force-pushed
the
fix/bank-frick-audit-followups
branch
from
July 24, 2026 21:14
57be1e7 to
6fbd62c
Compare
joshuakrueger-dfx
changed the title
frick-viban.provider.ts (availability guard, vban create/approve/ activation branch, fail-closed throw) is payout-adjacent logic that sat outside the strict test:frick:cov 100% gate. Add it to the gate (jest.frick.config.js + the test:frick:cov scope) alongside the seven existing Frick files; it already sits at 100% under its existing spec, so the gate is enforced, not merely declared.
joshuakrueger-dfx
force-pushed
the
fix/bank-frick-audit-followups
branch
from
July 24, 2026 21:26
6fbd62c to
23c287d
Compare
joshuakrueger-dfx
changed the title
joshuakrueger-dfx
marked this pull request as draft
July 25, 2026 10:00
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Rebased onto current develop and reduced to a single, self-contained guardrail. The other Bank Frick audit follow-ups originally bundled here have since landed on develop through their own PRs (asset-linked IBAN attribution via
selectAttributionBank; the ledger ASSET-active regression pin), and the per-provider monitoring-isolation change was dropped as an incomplete half-measure (it would trade a loud whole-cycle failure for a silent per-provider blind spot in/health, which has no staleness detection).Change
Add
frick-viban.provider.ts— availability guard, vban create/approve/activation branch, fail-closed throw (payout-adjacent logic) — to the stricttest:frick:cov100% coverage gate (jest.frick.config.js+ thetest:frick:covscript scope), alongside the seven existing Frick files. The file already sits at 100% under its existing spec, so the gate is enforced, not merely declared, and a future PR can no longer silently erode its coverage.PR completeness
Test plan
npm run test:frick:cov→ 8 suites, 303 tests, all eight Frick files (incl. frick-viban.provider.ts) at 100/100/100/100.prettier --checkclean on both changed files.