Release: develop -> main#4290
Merged
Merged
Conversation
) estimateSmartFee can return an estimate below the node's own minimum relay fee during periods of very low mempool activity, since Bitcoin Core's historical-inclusion estimator isn't bounded by the live relay-policy floor. Once the configured safety multiplier is applied, the resulting fee rate could still round to a value under 1 sat/vB, causing the node to reject the broadcast with "Fee rate is lower than the minimum fee rate setting". Clamp the value returned by getSendFeeRate() to a 1 sat/vB floor before it is handed to the send RPC. The unclamped estimate from getRecommendedFeeRate() is left untouched since it's also used for quoting/display. This is fixed in the shared base class, so it applies to both Bitcoin and Firo payouts.
github-actions
Bot
requested review from
TaprootFreak and
davidleomay
as code owners
July 20, 2026 13:34
TaprootFreak
approved these changes
Jul 20, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Automatic Release PR
This PR was automatically created after changes were pushed to develop.
Commits: 1 new commit(s)
Checklist