Release: develop -> main#4286
Merged
Merged
Conversation
…email that never arrives (#4283) * fix(realunit): confirm existing-shareholder registrations without an email that never arrives Aktionariat's registerUser answers "Existing user found, updated your address." when the signed email already belongs to a share-register shareholder: it updates that shareholder's wallet in place and sends NO confirmation email (a newly registered email instead gets "Confirmation email sent to ..."). Since #4215 gates buy quotes on a confirmed registration email, those registrations were persisted COMPLETED with requiresEmailConfirmation=true and hang forever on a confirmation link that is never sent. Persist an existing-shareholder registration with requiresEmailConfirmation=false (Aktionariat's match IS the confirmation), and backfill the rows already stuck before the fix, keyed on the durable Aktionariat/Registration log evidence. * fix(realunit): anchor existing-shareholder marker to the message start The isExistingShareholderResponse guard matched "existing user found" as a free substring of Aktionariat's registerUser reply. Because the alternative "Confirmation email sent to <email>" reply echoes the raw registrant email, an address embedding those words (e.g. a quoted local part) could spoof the marker and un-gate a registration whose confirmation email was in fact sent and never confirmed. Match it as a start-anchored prefix instead (the real reply is exactly "Existing user found, updated your address.") and add a regression test pinning the substring-spoof case as still gated. --------- Co-authored-by: TaprootFreak <142087526+TaprootFreak@users.noreply.github.com>
github-actions
Bot
requested review from
TaprootFreak and
davidleomay
as code owners
July 20, 2026 09:12
TaprootFreak
approved these changes
Jul 20, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Automatic Release PR
This PR was automatically created after changes were pushed to develop.
Commits: 1 new commit(s)
Checklist