Release: develop -> main#4243
Merged
Merged
Conversation
…dger and dashboard (#4233) * fix(bank): account for statement-inline charges across change log, ledger and dashboard Bank Frick statements carry the charge inline (chargeAmount and currency, never a CHF conversion, never a dedicated fee row), which none of the existing surfaces counted: - getBankTxFee gains a third source: inline charges without a CHF value aggregate per currency and convert like the fee-row source, with fee rows excluded so nothing double-counts - the ledger books the bank asset leg gross and adds an explicit EXPENSE/bank-fee leg (buy-fiat settlement and the bank-tx debit branches), valued through the same ladder as the checkout settlement - a booked debit that included a charge reconciles net of it instead of drifting against the balance feed or lumping into the fx plug - the dashboard reconciliation categorizes assets with a bank relation as bank before consulting the blockchain lists, matching the ledger's custody classification * fix(bank): bridge inline charges over missing historical marks, object relations form A charged row whose asset had no mark at the booking date threw before the mark bridge ever ran, wedging the scan behind it - the charge now values through the same latest-available-mark bridge as its asset leg (warn-logged, needsMark kept; unbridgeable suspense counters defer instead of fixing a phantom plug). Genuinely feedless assets and mismatched charge currencies still fail loud. Dashboard relations use the object form.
github-actions
Bot
requested review from
TaprootFreak and
davidleomay
as code owners
July 16, 2026 16:03
…#4242) Bank Frick's rows are receive=true so inbound money on its accounts is fully processed, but it must never be shown to customers as a deposit target. Filter it out of getBank so customers are always offered the incumbent banks (Olkypay/Yapeal); inbound crediting runs via BankTxFrickService and the outbound payout selector has its own Frick handling, so only the customer-facing deposit IBAN is affected.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Automatic Release PR
This PR was automatically created after changes were pushed to develop.
Commits: 1 new commit(s)
Checklist