Use same range calculations on both platforms - #318
Open
FreezePhoenix wants to merge 2 commits into
Open
Conversation
Refactor getReach method to use blockInteractionRange. Is it intentional that you are subtracting 0.5 when not in creative? The attribute value already has a different value if you're in creative.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This changes it so that the same code is used on both platforms, allowing this class to potentially be moved into the main code.
Is it intentional that you are checking for if the player is in creative mode, when the attribute already changes value if they are?