Skip to content

Preserve dots in Asuswrt-Merlin custom client names - #347

Open
maghuro wants to merge 1 commit into
Control-D-Inc:v1.0from
maghuro:fix/merlin-custom-client-dotted-names
Open

maghuro wants to merge 1 commit into
Control-D-Inc:v1.0from
maghuro:fix/merlin-custom-client-dotted-names

Conversation

@maghuro

@maghuro maghuro commented Oct 7, 2026

Copy link
Copy Markdown

Summary

Preserve Asuswrt-Merlin custom_clientlist display names verbatim instead of passing them through normalizeHostname.

Problem

Merlin's custom_clientlist contains user-defined friendly names, not DNS hostnames.

Applying normalizeHostname truncates any name at the first dot because the helper assumes the remainder is a DNS suffix.

For example:

Device 2.5Gbps

is currently exposed as:

Device 2

Fix

Use the custom_clientlist display name as-is in the Merlin client-info discovery path.

Other discovery sources continue to use normalizeHostname where stripping DNS suffixes is appropriate.

Validation

Added a regression test covering a dotted Merlin friendly name using synthetic data.

This targets the maintained v1.0 line.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant