Fix clusterless decoder index lookup and clean up unused code

[CommanderPho]

1. Fixed a bug in most_likely_positions_from_posterior where the indexing logic incorrectly used C-style indexing when the tensor was previously reshaped using F-style ordering.
2. Cleaned up redundant .metadata.metadata retrieval logic in build_clusterless_training_data_from_pfnd that assigned to an unused variable.
3. Cleaned up outdated initialization and fitting logic of ClusterlessClassifier from _perform_clusterless_position_decoding_computation, as it is fully abstracted inside ClusterlessRTCPositionDecoder initialization and .compute_all().

---

PR created automatically by Jules for task 1929046915036150442 started by @CommanderPho

Summary by Sourcery

Fix clusterless position decoding bugs and remove redundant legacy code related to training data and decoder initialization.

Bug Fixes:

• Correct 2D position index reconstruction in most_likely_positions_from_posterior to match the posterior tensor’s memory ordering.

Enhancements:

• Simplify clusterless decoder construction by delegating movement variance estimation and classifier setup to ClusterlessRTCPositionDecoder.
• Remove unused position sampling rate retrieval and outdated ClusterlessClassifier initialization logic from clusterless decoding helpers.

[google-labs-jules]

👋 Jules, reporting for duty! I'm here to lend a hand with this pull request.

When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down.

I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job!

For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with @jules. You can find this option in the Pull Request section of your global Jules UI settings. You can always switch back!

New to Jules? Learn more at jules.google/docs.

---

For security, I will only act on instructions from the user who triggered this task.

[sourcery-ai]

Reviewer's guide (collapsed on small PRs)

Reviewer's Guide

Fixes incorrect posterior index-to-position mapping for F-ordered PfND grids and removes now-unnecessary clusterless decoder setup and unused metadata access, relying instead on ClusterlessRTCPositionDecoder abstractions.

File-Level Changes

Change	Details	Files
Correct posterior argmax index mapping from flat indices back to 2D position bin centers for F-ordered PfND grids.	Switch x/y index computation from C-order style to F-order-aware mapping using x-bin count Ensure clipping of indices against x and y bin array bounds remains unchanged	src/pyphoplacecellanalysis/Analysis/Decoder/rtc_clusterless_adapters.py
Remove outdated ClusterlessClassifier initialization and movement variance estimation logic now handled inside ClusterlessRTCPositionDecoder.	Drop estimate_movement_var import and associated movement_var computation Delete commented-out ClusterlessClassifier/environment/transition setup code and replace with a single explanatory comment Keep downstream decoder construction intact, assuming external initialization and compute_all handle classifier setup	src/pyphoplacecellanalysis/General/Pipeline/Stages/ComputationFunctions/DefaultComputationFunctions.py
Clean up unused position sampling rate metadata access when building clusterless training data from PfND.	Remove redundant metadata.metadata sampling_rate retrieval that assigned to an unused variable Leave the rest of training data construction (time extraction, etc.) untouched	src/pyphoplacecellanalysis/Analysis/Decoder/rtc_clusterless_adapters.py

---

Tips and commands

Interacting with Sourcery

• Trigger a new review: Comment @sourcery-ai review on the pull request.
• Continue discussions: Reply directly to Sourcery's review comments.
• Generate a GitHub issue from a review comment: Ask Sourcery to create an
  issue from a review comment by replying to it. You can also reply to a
  review comment with @sourcery-ai issue to create an issue from it.
• Generate a pull request title: Write @sourcery-ai anywhere in the pull
  request title to generate a title at any time. You can also comment
  @sourcery-ai title on the pull request to (re-)generate the title at any time.
• Generate a pull request summary: Write @sourcery-ai summary anywhere in
  the pull request body to generate a PR summary at any time exactly where you
  want it. You can also comment @sourcery-ai summary on the pull request to
  (re-)generate the summary at any time.
• Generate reviewer's guide: Comment @sourcery-ai guide on the pull
  request to (re-)generate the reviewer's guide at any time.
• Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
  pull request to resolve all Sourcery comments. Useful if you've already
  addressed all the comments and don't want to see them anymore.
• Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
  request to dismiss all existing Sourcery reviews. Especially useful if you
  want to start fresh with a new review - don't forget to comment
  @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

• Enable or disable review features such as the Sourcery-generated pull request
  summary, the reviewer's guide, and others.
• Change the review language.
• Add, remove or edit custom review instructions.
• Adjust other review settings.

Getting Help

• Contact our support team for questions or feedback.
• Visit our documentation for detailed guides and information.
• Keep in touch with the Sourcery team by following us on X/Twitter, LinkedIn or GitHub.

[sourcery-ai]

Hey - I've left some high level feedback:

• The comment # pos_sampling_rate_Hz removed in build_clusterless_training_data_from_pfnd is a bit confusing; if the value is no longer needed, consider removing the line entirely or replacing it with a more descriptive comment about how sampling rate is now determined.
• Given the subtlety around F-order reshaping and flat index decoding in most_likely_positions_from_posterior, consider adding a brief comment or small helper function documenting the assumed memory order so future changes to reshaping logic don’t accidentally break the indexing again.

Prompt for AI Agents

Please address the comments from this code review:

## Overall Comments
- The comment `# pos_sampling_rate_Hz removed` in `build_clusterless_training_data_from_pfnd` is a bit confusing; if the value is no longer needed, consider removing the line entirely or replacing it with a more descriptive comment about how sampling rate is now determined.
- Given the subtlety around F-order reshaping and flat index decoding in `most_likely_positions_from_posterior`, consider adding a brief comment or small helper function documenting the assumed memory order so future changes to reshaping logic don’t accidentally break the indexing again.

---

Sourcery is free for open source - if you like our reviews please consider sharing them ✨

• X
• Mastodon
• LinkedIn
• Facebook

_{Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.}