support dynamic height rows for non-virtualized rendering#4040
Open
fastfrwrd wants to merge 5 commits into
Open
support dynamic height rows for non-virtualized rendering#4040fastfrwrd wants to merge 5 commits into
fastfrwrd wants to merge 5 commits into
Conversation
|
|
fastfrwrd
commented
May 12, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
auto,fit-content,stretch, etc.useViewportRowsto handle this, which adds new required new propselementandgridHeightwhen using a string-based height.Background
At Grafana, our react-data-grid fork has been powering our Table panel for the past 9 months or so. One of the features we really need in our table panel is a mode where dynamic content can be supplied by a datasource (see the Grafana docs).
We forked from the package when the decision was made in this project to drop support for React 18 on a non-breaking version update, but now that Grafana 13 is released and we are getting closer to having React 19 as the only supported version for Grafana going forward, we want to get back on the main package. But to do that we need dynamic row height support since we have added that in our fork and we now depend on that being available in some form. We're open to the specific form it takes, though, so please let us know if you have concerns with the approach in here.