fix(ModuleInstallerAPI): Rename class in DB recursively

[Hipska]

Base information

Question	Answer
Related to a SourceForge thread / Another PR / Combodo ticket?	N/A
Type of change?	Bug fix

Symptom

Using ModuleInstallerAPI::RenameClassInDB to rename classes does not work for classes having intermediate classes.

Renaming Child works:

• Parent
  • Child

Renaming Child does not work:

• Parent
  • Intermediate
    • Child

Reproduction procedure

1. Have an old datamodel where DB server objects are still called DBserver.
2. ModuleInstallerAPI::RenameClassInDB('DBserver', 'DBServer'); as done in itop-config-mgmt.
3. Run query SELECT SoftwareInstance

Observe the DB server objects not being listed (but they are counted in total objects).

Cause

The mentioned helper method only updates the finalclass field for the root class.

Proposed solution

Update the finalclass field for all parent classes recursively.

Checklist before requesting a review

• I have performed a self-review of my code
• I have tested all changes I made on an iTop instance
• I have added a unit test, otherwise I have explained why I couldn't
• Is the PR clear and detailed enough so anyone can understand digging in the code?

[Copilot]

Pull request overview

Fixes ModuleInstallerAPI::RenameClassInDB() so class renames are reflected in the DB for inheritance chains that include intermediate classes, preventing objects from “disappearing” from queries due to stale finalclass values.

Changes:

• Replace single-root-table update with an iteration over all parent classes of the target class to update finalclass consistently across the inheritance chain.
• Accumulate affected rows across all executed updates for logging.

---

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

[Hipska]

Probably it could also rename the objclass on CMDBChangeOp to be able to keep history after class rename.

[Hipska]

And the dest_class of SynchroReplica as well..

[Molkobain]

PR review: @Hipska we are ok to include this in the upcoming 3.4.0, but only if you add unit tests covering your changes until then.

[Hipska]

Great to hear. Could you help thinking of a scenario I could implement in a test?

[Molkobain]

@rquetiez any idea? You know the unit test APIs best.