Skip to content

London | 26-ITP-Sept | Fung Nin Lee | Sprint 1| formatAs12HourClock #1631

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
leerogerfn wants to merge 7 commits into
base: main
Choose a base branch
from
Open

London | 26-ITP-Sept | Fung Nin Lee | Sprint 1| formatAs12HourClock #1631

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
3d03d05
first revision of the function - tried to include all conditions.
leerogerfn Sep 30, 2026
cf5075f
modified the first confition in the function. include "-"
leerogerfn Sep 30, 2026
23d7cfd
modified the test.js
leerogerfn Sep 30, 2026
050f6e6
modified tests according to Abdi's comments.
leerogerfn Oct 1, 2026
23c127d
formatted documents
leerogerfn Oct 1, 2026
6836eaa
modified the format of the result. Corrected then typo in test.
leerogerfn Oct 2, 2026
09748a1
modifed the code of else.
leerogerfn Oct 3, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
19 changes: 14 additions & 5 deletions format-clock-edge-cases/timeConverter.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,11 +1,20 @@
function formatAs12HourClock(time) {

const hours = Number(time.slice(0, 2));
const minutes = time.slice(-2);

if (hours > 12) {
return `${hours - 12}:00 pm`;
if (hours > 24 || hours < 0 || time.includes("-")) {
return "invalid input.";
} else if (hours === 24 || hours === 0) {
return `${12}:${minutes} am`;
} else if (hours === 12) {
return `${hours}:${minutes} pm`;
} else if (hours > 12) {
return `${hours - 12}:${minutes} pm`;
} else {
return `${time.slice(0, 2)}:${minutes} am`;
}
return `${time} am`;
}

export {formatAs12HourClock};
export { formatAs12HourClock };

console.log(formatAs12HourClock("08:00"))
26 changes: 21 additions & 5 deletions format-clock-edge-cases/timeConverter.test.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,11 +1,27 @@
import {formatAs12HourClock} from "./timeConverter.js";
import { formatAs12HourClock } from "./timeConverter.js";
import assert from "node:assert";
import test from "node:test";

test("correctly convert time after 12:00", function(){
assert.equal(formatAs12HourClock("23:00"), "11:00 pm");
test("correctly convert time afternoon time: 23:00", function () {
assert.equal(formatAs12HourClock("23:00"), "11:00 pm");
});

test("can correctly convert morning time", function() {
assert.equal(formatAs12HourClock("08:00"), "08:00 am");
test("can correctly convert morning time 08:00", function () {
assert.equal(formatAs12HourClock("08:00"), "08:00 am");
});

test("can correctly convert morning time 11:59", function () {
assert.equal(formatAs12HourClock("11:59"), "11:59 am");
});

test("can correctly convert afternoon time 23:59", function () {
assert.equal(formatAs12HourClock("23:59"), "11:59 pm");
});

test("can correctly convert morning time 00:00", function () {
assert.equal(formatAs12HourClock("00:00"), "12:00 am");
});

test("can correctly convert afternoon time 12:00", function () {
assert.equal(formatAs12HourClock("12:00"), "12:00 pm");
});
Loading